Add ci-operator config for SNO day2-worker 4.18 CI lane#79357
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a CI-operator config for the cnf-ran-sno-day2-worker-4.18 variant (build root, OCP 4.18 candidate, global resources, cnf-ran-ztp-tests with env/subscriptions, phase wiring, metadata) and sets ANSIBLE_JINJA2_NATIVE=true for the hub deploy playbook invocation. ChangesCI Configuration Variant
Hub Deploy
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: Suggested reviewers:
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`:
- Line 23: The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f0ce3fdd-ec34-46a8-badb-63682a312fe6
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml
| - as: cnf-ran-ztp-tests | ||
| capabilities: | ||
| - intranet | ||
| cron: 0 0 31 2 * |
There was a problem hiding this comment.
Cron schedule is unschedulable.
Line 23 uses 0 0 31 2 *, which never triggers (February has no 31st). This effectively disables the periodic lane.
Suggested fix
- cron: 0 0 31 2 *
+ cron: 0 0 * * *📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cron: 0 0 31 2 * | |
| cron: 0 0 * * * |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`
at line 23, The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
from
6983a25 to
d0fa40e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdiscala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rdiscala: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
This PR adds a new ci-operator variant for the openshift-kni/eco-ci-cd component to run the Single Node OpenShift (SNO) day2-worker CI lane against OpenShift 4.18: cnf-ran-sno-day2-worker-4.18. The change lives in openshift/release CI config and does the following:
Adds ci-operator config (ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml) that:
Updates the telcov10n hub-deploy step script (ci-operator/step-registry/telcov10n/functional/cnf-ran/hub-deploy/telcov10n-functional-cnf-ran-hub-deploy-commands.sh) to set ANSIBLE_JINJA2_NATIVE=true when running the ansible-playbook for deploy-ocp-sno (affects Jinja2 template evaluation during SNO deployment).
In practical terms this enables running the SNO day2-worker CI lane for eco-ci-cd against OpenShift 4.18 using the same hardware and operator channel selections as the existing 4.20 variant, plus a script tweak to use native Jinja2 behavior for the SNO deploy playbook.